This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]:libxl__get_free_memory_slack cannot return when

To: "Jun Zhu (Intern)" <Jun.Zhu@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]:libxl__get_free_memory_slack cannot return when creating a vm by xl
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 27 Sep 2010 11:39:43 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 27 Sep 2010 03:40:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <433DDF91DFB08148BAD3FDB6FDDA314C9F3703C5FF@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <433DDF91DFB08148BAD3FDB6FDDA314C9F3703C5FF@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Sun, 26 Sep 2010, Jun Zhu (Intern) wrote:
> Hi,
> This patch fixes the problem when xl create invokes 
> libxl__get_free_memory_slack which does not return. In the 
> libxl__fill_dom0_memory_info function, if */memory/target is existed, it 
> returns directly, leaving */memory/freemem-slack still empty. 
> I don't think it is necessory to check */memory/target in the function 
> libxl__fill_dom0_memory_info, since this function is to fill the dom0???s 
> memory info. Moreover, it is not correct to believe that 
> */memory/freemem-slack exists by checking */memory/target. 

How did you get in the state of having the target on xenstore but not
If you are using libxl this shouldn't be possible unless you mess around
with xenstore directly.

Xen-devel mailing list