This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] accumulate_guest_flags no longer exists in xen 3.4.3

To: "K.C. Lee" <kcl.joseph@xxxxxxxxx>
Subject: Re: [Xen-devel] accumulate_guest_flags no longer exists in xen 3.4.3
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 27 Sep 2010 10:51:45 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 27 Sep 2010 02:54:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTik=qL-oO-9g_Y-cjVrYBw90hWMyziuCYenOtUG3@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTik=qL-oO-9g_Y-cjVrYBw90hWMyziuCYenOtUG3@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 04:35 +0100 on 27 Sep (1285562121), K.C. Lee wrote:
> Hi,
> I found that accumulate_guest_flags(struct vcpu *v, walk_t *gw) defined in 
> xen 3.1.0 could not be found in xen 3.4.3.
> Also, I found that guest_walk_tables(struct vcpu *v, unsigned long va, walk_t 
> *gw, ...) in xen 3.4.3 contanis code block: "guest_l1e_get_flags(gw->eff_l1e) 
> ^ _PAGE_NX_BIT" which can only be found in accumulate_guest_flags. Besides, I 
> also found a comment in "We will accumulate, in rc, the set of flags that are 
> missing".
> I want to know if accumulate_guest_flags integrated into guest_walk_tables in 
> the version of xen 3.4.3?

Yes.  The HAP code had introduced its own pagetable-walking routines
which were missing some logic; they were merged with the original
shadow-code pagetable walker.

> And if so, how can I use guest_walk_tables instead of accumulate_guest_flags 
> to get the same return value and walk_t *gw?

What exactly are you trying to do?  For most purposes the function you
need is paging_gva_to_gfn(), which will find and walk the guest's
pagetables for you, and figure out the pagefault error code if you need
to inject a pagefault.



> Any suggestion is appreciated.
> Thank you very much.

Content-Description: ATT00001..txt
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list