[Xen-devel] Re: wrong logrotate for /var/log/xen/xend.log

[Olaf Hering <ohering@xxxxxxxxxx>]

On Tue, Sep 14, Olaf Hering wrote:

> On Tue, Sep 14, Olaf Hering wrote:
> 
> > [2010-09-14 13:24:30 4625] ERROR (xmlrpclib2:178) Internal error handling 
> > xend.domain
> 
> Poking around, something is leaking ressources in xenstored:
> 
> 
> accept(4, 0, NULL)                      = -1 EMFILE (Too many open files)
> select(1024, [4 ... 1023], [], NULL, NULL) = 1 (in [4])
> 
> 
> pidof xenpaging | xargs -n1 lsof -n -p | grep -wc socket
> 1000

Which is fixed by this missing change in 4.0.1:


Missing from commit 'libxl: Backported stuff from unstable'
Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors.

--- a/tools/xenstore/xs.c       2010-07-19 16:14:15.000000000 +0200
+++ b/tools/xenstore/xs.c       2010-09-13 15:46:24.000000000 +0200
@@ -285,6 +299,8 @@ void xs_daemon_close(struct xs_handle *h
        mutex_unlock(&h->request_mutex);
        mutex_unlock(&h->reply_mutex);
        mutex_unlock(&h->watch_mutex);
+
+        close_fds_free(h);
 }
 
 static bool read_all(int fd, void *data, unsigned int len)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel