This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xsm: return unlabeled instead of failing with ENOENT

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xsm: return unlabeled instead of failing with ENOENT in get_page_sid
From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Date: Wed, 22 Sep 2010 12:56:15 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 22 Sep 2010 09:57:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: National Security Agency
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Thunderbird/3.1.2
It is better to return an unlabeled SID in the case where dsec is NULL
instead of bailing out with an error.

diff -r 5393151a737b xen/xsm/flask/hooks.c
--- a/xen/xsm/flask/hooks.c     Tue Sep 14 18:26:10 2010 +0100
+++ b/xen/xsm/flask/hooks.c     Wed Sep 22 12:49:54 2010 -0400
@@ -343,7 +343,7 @@
             if (dsec)
                 *sid = dsec->sid;
-                rc = -ENOENT;
+                *sid = SECINITSID_UNLABELED;

Daniel De Graaf
National Security Agency

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xsm: return unlabeled instead of failing with ENOENT in get_page_sid, Daniel De Graaf <=