This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] x86/hvm: fix extra size passed to __trace_var()

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86/hvm: fix extra size passed to __trace_var()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 20 Sep 2010 14:39:31 +0100
Delivery-date: Mon, 20 Sep 2010 06:40:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
While removing the casts on the last arguments to __trace_var() I
noticed the bogus addition of 1 here.

This patch will only apply on top of said earlier one.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2010-08-12.orig/xen/include/asm-x86/hvm/trace.h     2010-09-10 
18:01:59.000000000 +0200
+++ 2010-08-12/xen/include/asm-x86/hvm/trace.h  2010-09-10 18:08:27.000000000 
@@ -72,7 +72,7 @@
             _d.d[4]=(d5);                                               \
             _d.d[5]=(d6);                                               \
             __trace_var(TRC_HVM_ ## evt, cycles,                        \
-                        sizeof(u32)*count+1, &_d);                      \
+                        sizeof(*_d.d) * count, &_d);                    \
         }                                                               \
     } while(0)

Attachment: x86-hvm-trace-extra-size.patch
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86/hvm: fix extra size passed to __trace_var(), Jan Beulich <=