This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] Make NIC model fallback to default when specifie

To: Michal Novotny <minovotn@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Make NIC model fallback to default when specified model is not supported
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Mon, 20 Sep 2010 14:07:19 +0200
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 20 Sep 2010 05:08:21 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=KAdLBAqtt7606UvciSBWG9X5kmvaArTtGH/2PV+0DG4=; b=ijDo9BOR6oPkxCN0XT8PsrXiFo6KWevlT+cKIzOiFDfvWJAGf4YE4dje3u8C++75Co 3Sfv/fU2kzGA9jBcyvpqQRp4jL0nZ3LwGWLrumlKth81KDwifAbNIGii+Aelf3YzAd9T DB0g4Su4XtEZmb+AnZqCF7+mtCaBPqazDEDTs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=UoDiaZ+yQ6r4W0P62CekY/jYADgpwKRTLVE9C4QmIR/MTB+IrPzkNLqVGNvZeUBn/D pPxWuxpW2bnd9ywjomheBa8ixLViHcgj2MLSqTNWae6PM+diFpyPWaCanaVq3pT10hYm 6HKVsw3U2a6nXYRN7uJ7zAs78yuLnimDhRr0k=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C9735C0.5000806@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C9735C0.5000806@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3
On 09/20/2010 12:21 PM, Michal Novotny wrote:
this is the patch to introduce a NIC model fallback to default when model
specified is not supported. It's been tested on x86_64 host with current
version of qemu-dm using the RHEL-5 i386 virtual machine and by trying to
setup the invalid (unsupported) model of NIC device. Also, the new constant
in the net.h called the DEFAULT_NIC_MODEL has been introduced to be able to
change the default NIC model easily. This variable is being used to set
the default NIC model when necessary.

It's been tested by running a guest with NIC model set to be "eee" which
is not supported and when the guest was started I tried to issue "lspci"
to list all the PCI devices and there was Realtek RTL-8239 (AS) card
which is basically the ne2k_pci card (default for Xen-4.1 qemu-dm) so
the old default has been preserved and it's being used as a fallback.

I don't think qemu-dm and upstream QEMU should diverge again, so this patch does not sound like a good thing for Xen's ioemu codebase.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>