This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [Patch] update cpumask handling for cpu pools in lib

On Fri, 2010-09-17 at 11:04 +0100, Juergen Gross wrote:
> On 09/17/10 11:44, Ian Campbell wrote:
> > On Fri, 2010-09-17 at 10:20 +0100, Juergen Gross wrote:
> >> On 09/17/10 11:00, Ian Campbell wrote:
> >>> local_size has already been rounded up in get_cpumap_size. Do we really
> >>> need to do it again?
> >>
> >> I've made it more clear that this is rounding to uint64.
> >
> > Wouldn't that be "(.. + 63) / 8" then?
> No, local_size is already bytes...

Oh yeah.

I think that helps make my point about the confusion inherent in using
variously bits, bytes and uint64s as you move up the callstack ;-)

> This would suggest changing xc_vcpu_setaffinity() and

Not sure if others will agree but personally I'd be fine with that.


Xen-devel mailing list