This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] A simple clean up of __get_instruction_length & __update

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Eddie Dong <eddie.dong@xxxxxxxxx>
Subject: Re: [Xen-devel] A simple clean up of __get_instruction_length & __update_guest_eip
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 16:38:23 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Sep 2010 08:39:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C91018C02000078000165DD@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActU6jrGerF4AsusRh+/TTb3yvjmyAAAc0EB
Thread-topic: [Xen-devel] A simple clean up of __get_instruction_length & __update_guest_eip
User-agent: Microsoft-Entourage/
On 15/09/2010 16:25, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Is it really a good idea to remove all these "Safe: ..." comments?
> Without them, I think it'll be much easier to not remember that
> this cannot be done everywhere and hence to add an inappropriate
> call to this function.

I meant to check they were kept, and then forgot and applied it anyway. I'll
add them back in.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>