This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Clear device-model information when destroying a

To: "Jun Zhu (Intern)" <Jun.Zhu@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Clear device-model information when destroying an HVM domain with stubdom-v3
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 10 Sep 2010 18:24:07 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 10 Sep 2010 10:24:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB63@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB63@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jun Zhu (Intern) writes ("RE: [Xen-devel] [PATCH] Clear device-model 
information when destroying an HVM domain with stubdom-v3"):
> Thanks for your suggesion. I use goto out in both wrong condition,
> and remove the unnecessory logging. The vim tabs has been converted
> to 4 spaces.

Thanks.  You still need to put { and } on the same line as the else :-).

Also, more seriously:

> +        } else {
> +            XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "failed to kill Device Model 
> [%d]",
> +                    atoi(pid));
> +            goto out;

This should set ret to something appropriate.  ERROR_FAIL, probably.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>