This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Avoid null dereference in flask get_page_sid

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Avoid null dereference in flask get_page_sid
From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Date: Wed, 8 Sep 2010 12:21:02 -0400
Delivery-date: Wed, 08 Sep 2010 09:21:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-12-10)
When booting Xen with flask enabled, dom0 memory specified to 1G,
and no policy loaded, I was able to produce a crash in get_page_sid.
The following patch appears to fix the issue, but I'm not sure if this
is the best response when given a page that does not have a label.

Xen call trace:
   [<ffff82c48014e9e9>] get_page_sid+0x87/0x93
   [<ffff82c48014eaea>] get_mfn_sid+0x56/0x6e
   [<ffff82c48014f491>] flask_mmu_normal_update+0xbc/0xeb
   [<ffff82c48017c099>] do_mmu_update+0x378/0x1927
   [<ffff82c480113989>] do_multicall+0x29d/0x438
   [<ffff82c480207cb2>] syscall_enter+0xf2/0x14c

--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -345,7 +345,10 @@
             /*Pages are implicitly labeled by domain ownership!*/
             dsec = d->ssid;
-            *sid = dsec->sid;
+            if (dsec)
+                *sid = dsec->sid;
+            else
+                rc = -ENOENT;
Daniel De Graaf
National Security Agency

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Avoid null dereference in flask get_page_sid, Daniel De Graaf <=