This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [advices] patch for dynamically changing vif rate via pr

To: ahmed amamou <ahmed.amamou@xxxxxxx>
Subject: [Xen-devel] Re: [advices] patch for dynamically changing vif rate via proc file
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 03 Sep 2010 12:43:38 -0700
Cc: "chrisw@xxxxxxxxxxxx" <chrisw@xxxxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 03 Sep 2010 12:46:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTinph=1Ua7gSV845gUBOkfuUnmw43XX9R7jq04EE@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTinph=1Ua7gSV845gUBOkfuUnmw43XX9R7jq04EE@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2
 On 09/02/2010 03:03 AM, ahmed amamou wrote:
> Hi Jermey and Chris,
> Sorry to bother you with this but as Maintainers  of XEN HYPERVISOR
> INTERFACE ,i wanted to ask you something
> I trying to make a patch that would allow me to dynamically change vif
> rate from a /proc file
> change written in proc file will be saved and value of
> netif->credit_usec and netif->credit_bytes will be assigned on the
> next tx_credit_exceeded check
> the patch mat be ready before the end of the day if you want i'll send
> you it as soon as i finish
> i just wanted to ask you if it was a good way to change vif rate from
> a proc file,as a beginner i don't really know to much of best
> practises in modules programming

/proc is definitely the wrong API for this.

For this kind of thing, its probably better to either use netlink, or
xenbus (xenstore) to keep this kind of per-interface parameter tuning.

But it isn't even clear that doing it at the device level is correct
anyway.  If the guest wants to control its own network traffic, or if
dom0 wants to control the guest traffic, there are many generic
mechanisms for doing traffic shaping.

What are you trying to achieve?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>