This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Crash in __pirq_guest_eoi()

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Crash in __pirq_guest_eoi()
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 03 Sep 2010 11:33:38 -0700
Cc: "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Fri, 03 Sep 2010 11:34:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2
 I'm seeing a crash in:

static void __pirq_guest_eoi(struct domain *d, int pirq)
    struct irq_desc         *desc;
    irq_guest_action_t *action;
    cpumask_t           cpu_eoi_map;
    int                 irq;

    desc = domain_spin_lock_irq_desc(d, pirq, NULL);
    if ( desc == NULL )

    action = (irq_guest_action_t *)desc->action;
    irq = desc - irq_desc;

    if ( action->ack_type == ACKTYPE_NONE )

where action is NULL.

I'm playing around with the pvops kernel's handling of pirq interrupts,
so the kernel is probably misbehaving, but it would be nice if Xen
didn't keep crashing on me.

I guess this is the right fix/workaround?

diff -r d37dc6401a1f xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c        Thu Sep 02 17:44:46 2010 +0100
+++ b/xen/arch/x86/irq.c        Fri Sep 03 11:33:15 2010 -0700
@@ -1028,6 +1028,9 @@
     action = (irq_guest_action_t *)desc->action;
     irq = desc - irq_desc;
+    if ( action == NULL )
+       return;
     if ( action->ack_type == ACKTYPE_NONE )
         ASSERT(!test_bit(pirq, d->pirq_mask));


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>