This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xl: do not return to caller from monitoring daemon

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xl: do not return to caller from monitoring daemon
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 03 Sep 2010 16:52:56 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Fri, 03 Sep 2010 08:55:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1283529150 -3600
# Node ID be28cc7f45bbe2a592b2405e3130c8e537859ba8
# Parent  f2c0e187de98560ed6c7104cf6b2d4f9291b4704
xl: do not return to caller from monitoring daemon

The parent process will have returned to the caller and done whatever
is necessary. The daemon should not return otherwise it will repeat
this work. In the case of the migration receiver this causes it to try
and take part in the migration protocol long after the sender+parent
process have completed it, leading to confusing error messages
(although strangely not much actual damange).

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r f2c0e187de98 -r be28cc7f45bb tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Fri Sep 03 15:56:11 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Fri Sep 03 16:52:30 2010 +0100
@@ -1635,6 +1635,12 @@ out:
+    /*
+     * If we have daemonized then do not return to the caller -- this
+     * has already happened in the parent.
+     */
+    if ( !need_daemon )
+        exit(ret);
     return ret;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>