This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 0/2] [RFC] xl: add cpuid config file option

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 0/2] [RFC] xl: add cpuid config file option
From: Andre Przywara <andre.przywara@xxxxxxx>
Date: Wed, 1 Sep 2010 11:01:31 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 01 Sep 2010 03:06:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19581.16081.41312.69006@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C77B5EE.2050403@xxxxxxx> <alpine.DEB.2.00.1008301419030.2545@kaball-desktop> <19581.16081.41312.69006@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090820)
Ian Jackson wrote:
Stefano Stabellini writes ("[Xen-devel] Re: [PATCH 0/2] [RFC] xl: add cpuid config 
file option"):
On Fri, 27 Aug 2010, Andre Przywara wrote:
This first version works for me, I'd like to hear your comments.
I like your approach. Ian, what do you think?

I think this is a nice approach.  But there didn't seem to be a patch
attached to your mail ? :-)

We would still need another parser for backward compatibility

Is it possible to distinguish the old xend syntax and so have libxl
handle either ?  I'm not familiar with the xend cpuid syntax.
xm uses a Python list syntax, so this looks different. It is possible to tell them apart: Currently you can check the return value of xlu_cfg_get_list() to try the new approach otherwise, but this prints an ugly warning to the console. So I created a (silent) get_type function to check it before calling the respective functions. The prototype works already, I will test and polish and then send out a second version later.

Also I think that parse_cpuid belongs to libxl instead of xl.

You are right, I have already moved it (in v2).


Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] Re: [PATCH 0/2] [RFC] xl: add cpuid config file option, Andre Przywara <=