WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 20 of 26] xl: free all data on exit from the doma

On Tue, 2010-08-17 at 16:11 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 20 of 26] xl: free all data on 
> exit from the domain monitor daemon"):
> > I think it needs an out_closelog label which does the closing since the
> > regular out label is used from places which do not open the logfile.
> > I'll make that change.
> 
> You could avoid messing about with different out labels (always
> error-prone) by closing logfile iff it has been reopened:
>   if (logfile != 2) close(logfile)

That's actually what I ended up doing. I'll repost tomorrow once I've
had a chance to rebase on top ofthe applied subset.

(I'll pull this one to the front of the series as well since it's really
a generic fix)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>