WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] xen: PV on HVM: support PV spinlocks

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] xen: PV on HVM: support PV spinlocks
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 16 Aug 2010 12:56:24 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 16 Aug 2010 04:57:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C65B681.8040408@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1008132006020.2545@kaball-desktop> <4C65B681.8040408@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 13 Aug 2010, Jeremy Fitzhardinge wrote:
>  On 08/13/2010 12:06 PM, Stefano Stabellini wrote:
> > xen: PV on HVM: support PV spinlocks
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >
> > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> > index 6f53453..5643c43 100644
> > --- a/arch/x86/xen/enlighten.c
> > +++ b/arch/x86/xen/enlighten.c
> > @@ -1290,6 +1290,8 @@ static int __cpuinit xen_hvm_cpu_notify(struct 
> > notifier_block *self,
> >     switch (action) {
> >     case CPU_UP_PREPARE:
> >             per_cpu(xen_vcpu, cpu) = 
> > &HYPERVISOR_shared_info->vcpu_info[cpu];
> > +           if (xen_have_vector_callback)
> > +                   xen_init_lock_cpu(cpu);
> 
> Why does this depend on vector_callback?  pv spinlocks never have events
> actually delivered.
> 

HVM guests cannot receive events on vcpus other than 0 without
vector_callback, this means they wouldn't receive even a vcpu_kick and
would get stuck.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>