WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenoprof: Cleanup

To: "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenoprof: Cleanup
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 10 Aug 2010 16:55:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Aug 2010 08:55:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100806.111754.183128568.kuwa@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20100806.111754.183128568.kuwa@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
...
> -/* AMD IBS support */
> -extern u32 ibs_caps;

But, in xen/common/xenoprof.c, surely this should be a definition and
not a declaration.  So more correct would be

 -extern u32 ibs_caps;
 +u32 ibs_caps;

but that would conflict with the #define in
xen/include/asm-ia64/xenoprof.h.  So I'm not sure this fix is complete.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>