 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output |
| From: | George Dunlap <dunlapg@xxxxxxxxx> |
| Date: | Tue, 3 Aug 2010 17:39:12 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Delivery-date: | Tue, 03 Aug 2010 09:40:16 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=rlWN7WJw3ZdJfJa6f5zwXhcEmlhOLckZ2wz11RH2CDQ=; b=Bx5+1ZF/gJzvYGI2A0OSo7PkUz2dVehLWI12FvSKr58QZ5NhJpqthFG6uAPv6Q0SRU 6xYFV25+Xuqd31+FICXAW1cRnrsi83B7hw+ucmNz9/YiosuKGoHtMvNSKXmC/yBOyZNj h+GRvRamHB9/aEXpoJX013nru124FXHMonoHw= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=qwIA+k3UpTS5Qz25lTdbdJqk7rlcQMkdmbpK8xDyKIiyWork0KNzZ8GTae2yk/eUq2 5FY0xGWu1NtyKwVf7nrSfflCLgY4W/IHm2bkC5LkpS08M6ia/xb7wdHqk8rh9WFgyWkR lk8lwUKZnSEDgseS3MHSMciZ1j4eBz0l0bA1I= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201008031824.21390.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <201008031824.21390.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
NACK for discussion. What do you mean they're "mixed up"? Putting the 64-bit value first makes it easy to define a structure you can just point directly at the binary data. If xentrace_format is different, wouldnt' it be easier to change it than the hypervisor? -George On Tue, Aug 3, 2010 at 5:24 PM, Christoph Egger <Christoph.Egger@xxxxxxx> wrote: > > Hi! > > Attached patch corrects MSR read/write trace output. > Also avoid duplicate MSR read/write lines in xentrace output. > MSR and value are mixed up. > > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx> > > -- > ---to satisfy European Law for business letters: > Advanced Micro Devices GmbH > Einsteinring 24, 85609 Dornach b. Muenchen > Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd > Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen > Registergericht Muenchen, HRB Nr. 43632 > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] xen: fix MSR xentrace output, Christoph Egger |
|---|---|
| Next by Date: | Re: [Xen-devel] libxl: typo in error message, Stefano Stabellini |
| Previous by Thread: | [Xen-devel] [PATCH] xen: fix MSR xentrace output, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] xen: fix MSR xentrace output, George Dunlap |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
