WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 5 of 9] xl: Add function to generate random uuid

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 5 of 9] xl: Add function to generate random uuid and use it
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Tue, 27 Jul 2010 17:07:59 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Delivery-date: Tue, 27 Jul 2010 09:08:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19535.804.805818.163051@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <a31105a3eb9d57d03711.1280225627@xxxxxxxxxxxxxxxxxxxxx> <1280231257.1723.2066.camel@xxxxxxxxxxxxxxxxxxxxxx> <19535.804.805818.163051@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-07-27 at 17:02 +0100, Ian Jackson wrote:
> Gianni Tedesco writes ("Re: [Xen-devel] [PATCH 5 of 9] xl: Add function to 
> generate random uuid and use it"):
> > Nothing wrong with the patch but draws my attention to the fact that
> > this method seems far too likely to collide UUID's, for example in xl
> > invocations started during the same second. Why not use system entropy
> > pool? eg. scanf contents of /proc/sys/kernel/rand/uuid... I'm aware this
> > ought to be portable but PRNG can always be a fallback.
> 
> Yes.
> 
> We should probably use /dev/urandom (on Linux, or I think /dev/random
> on BSD).  If that's not available then we should use rand_r seeded
> with time and pid.

Or perhaps libuuid? It's is used by blktap2 so we already need it, at
least on Linux.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>