WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Introduce dom0-min-space configuration option

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Introduce dom0-min-space configuration option
From: Michal Novotny <minovotn@xxxxxxxxxx>
Date: Mon, 26 Jul 2010 08:55:06 +0200
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 25 Jul 2010 23:56:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19529.48273.52500.896247@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C3B59FE.2060201@xxxxxxxxxx> <19516.43557.723062.885082@xxxxxxxxxxxxxxxxxxxxxxxx> <4C3D9E22.3030302@xxxxxxxxxx> <19526.62789.227136.192517@xxxxxxxxxxxxxxxxxxxxxxxx> <4C47F857.4060606@xxxxxxxxxx> <19529.48273.52500.896247@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4
On 07/23/2010 06:00 PM, Ian Jackson wrote:
Michal Novotny writes ("Re: [Xen-devel] [PATCH] Introduce dom0-min-space 
configuration option"):
Well, there's no other way to fix it than to implement a check for
enough space on dom0 for extracting vmlinuz and initrd files from the
image file. If it's partially extracted it's understandable that the
data are not valid input for zStream processing and therefore it runs
into Z_BUF_ERROR (-5) during the process.
No, it is not understandable that the system should continue to try to
execute a partially-extracted kernel.  This needs to be fixed.

Well, if the kernel is extracted partially could it get decompressed well? I don't think so since there's a data stream missing.

Why do you think my patch is entirely wrong?
Because you are treating the symptoms but not addressing the cause.

Ian.

From what I know this is caused by insufficient disk space and therefore the kernel and/or initrd are extracted just partially so there's no valid end of the input data stream.

I think that making sure that the data will be extracted fully and successfully from the image file is fixing the root cause. Or do you think that we should alter the message in gunzip function to say that there's an error in data stream (premature end of data stream) and that user should check for enough space on dom0?

Michal

--
Michal Novotny<minovotn@xxxxxxxxxx>, RHCE
Virtualization Team (xen userspace), Red Hat


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>