WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] x86: unconditionally mark TSC unstable under

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] x86: unconditionally mark TSC unstable under Xen
From: Jed Smith <jed@xxxxxxxxxx>
Date: Wed, 14 Jul 2010 18:29:48 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 14 Jul 2010 15:31:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C3E2DCC.1010201@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <51C8308F-F413-47AF-8845-C92BD36CA35C@xxxxxxxxxx> <4C3E2DCC.1010201@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Jul 14, 2010, at 5:36 PM, Jeremy Fitzhardinge wrote:

> On 07/14/2010 12:24 PM, Jed Smith wrote:
>> Jeremy, Jan - what do you think?  Is this a bad move?  I feel like there
>> is a consequence to this that I am unaware of, but it fixes my issue.
>> 
> 
> Ah, well that's interesting.
> 
> There's a couple of comments:
> 
>   1. you can't do this with just a compile-time test, since the same
>      kernel can also boot native
>   2. nothing in a Xen PV domU environment should be using the tsc
>      directly, so this shouldn't have an effect.  If something is using
>      the tsc we should track it down.
> 
> I wonder, however, if you're getting the same result as Jan's suggestion
> of making sched_clock unstable by making the tsc unstable.

That's what I went for - I had initially just commented out the assignment
of sched_clock_stable to 1, which fixed it, but this felt cleaner.

> In that case, this patch may help:

Will try and report.

Regards,

Jed Smith
Systems Administrator
Linode, LLC
+1 (609) 593-7103 x1209
jed@xxxxxxxxxx


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel