WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Register watches for frontend features.

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Register watches for frontend features.
From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
Date: Fri, 9 Jul 2010 13:53:05 +0100
Accept-language: en-US
Acceptlanguage: en-US
Cc: Ian, Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 09 Jul 2010 05:54:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C34C320.2010102@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1278329973-12414-1-git-send-email-paul.durrant@xxxxxxxxxx> <4C34C320.2010102@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acsd/8LjOrz8p4+0QyCKNiOjFAeZMABZPQ+A
Thread-topic: [Xen-devel] [PATCH] Register watches for frontend features.
> -----Original Message-----
> From: Jeremy Fitzhardinge [mailto:jeremy@xxxxxxxx]
> Sent: 07 July 2010 19:11
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Ian Campbell
> Subject: Re: [Xen-devel] [PATCH] Register watches for frontend
> features.
> 
> On 07/05/2010 04:39 AM, Paul Durrant wrote:
> > Frontend features are currently only sampled at ring connection
> time.
> > Some frontends can change these features dynamically so watches
> should
> > be used to update the corresponding netback flags as and when they
> > change.
> >
> 
> Are there any concerns about these feature flags changing
> asynchronously?
> 
> The watches will run in their own task, and so can be concurrent to
> the
> netback code using the flags.  What prevents that from upsetting the
> tests of the flags in, for example, netbk_max_required_rx_slots?
> Should
> there be some locking?  Or double-buffer the feature flags so that
> the
> netback code can get updated values at a safe/appropriate time?
> 
> Can all features be changed dynamically by the frontend, or just
> some?
> 

Realistically, with a Windows frontend, the only ones that are going to change 
dynamically are gso_prefix and csum. I can 'de-watch' the others, if you'd 
prefer.
As for locking, it's not clear to me how fatal getting 
netbk_max_required_rx_slots wrong is. However, losing or gaining gso/gso_prefix 
part way through a receive is not going to be good so I thing some double 
buffering is probably called for. I'll re-work the patch accordingly.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>