WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/3] x2APIC improvement

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/3] x2APIC improvement
From: Weidong Han <weidong.han@xxxxxxxxx>
Date: Thu, 08 Jul 2010 10:31:00 +0800
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 07 Jul 2010 19:31:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100707135656.GD4823@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1A42CE6F5F474C41B63392A5F80372B21F67B00E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100706144915.GB5408@xxxxxxxxxxxxxxxxxxx> <4C340BF4.0@xxxxxxxxx> <20100707135656.GD4823@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)
Konrad Rzeszutek Wilk wrote:
On Wed, Jul 07, 2010 at 01:09:08PM +0800, Weidong Han wrote:
Konrad Rzeszutek Wilk wrote:
On Mon, Jul 05, 2010 at 03:07:58PM +0800, Han, Weidong wrote:
The patchset improves Xen x2APIC support.

Patch 1/3: allocate iommu when create a drhd
        A drhd is created when parse ACPI DMAR table, but drhd->iommu is not 
allocated until iommu setup. But iommu is needed by x2APIC which will enable interrupt 
remapping before iommu setup. This patch allocates iommu when create drhd. And then 
drhd->ecap can be removed because it's the same as iommu->ecap.

Have these patches been tested on a machine where the number of DRHD !=
number of IOAPICs?

Why need to care about number of DRHD != number of IOAPICs? One DRHD
may cover more than one IOAPICs. And there is already check if all

And the inverse might be true as well - in which case we should disable
x2APIC.

Each IOAPIC must have a corresponding DRHD, but a DRHD maybe don't have a IOAPIC in its device scope. So it won't enable x2APIC if there is any IOAPIC which doesn't have corresponding DRHD.
IOAPICs have corresponding DRHD.

I understand. I am asking whether these patches have not changed that
behavior and whether you have tested for that.
These patches don't change that behavior.

Regards,
Weidong


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>