WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [XEN][vNUMA][PATCH 7/9] Build NUMA HVM

To: Dulloor <dulloor@xxxxxxxxx>
Subject: Re: [Xen-devel] [XEN][vNUMA][PATCH 7/9] Build NUMA HVM
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Tue, 6 Jul 2010 11:09:20 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 06 Jul 2010 03:10:10 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=qMQHzPK8zwCPirAgznurebp6idOgplI6BaA53ur/+8U=; b=w76w3bYa8RVTfX8Xc234vFh8b5L4xKz6i3UO0f7f9aE0Mc0DIkzf4omOstbLu4fda0 HzDqph5uwAXUTCiuOUw7Xr0o1NOiebJTC+EI0n9CLbDJLvitx7yvKOExH5xl9yrw2t6V 55gWnfJ5gZZnhEzmDlK0NzDFOiy/LpJKV8qVI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=u3W43NpFuEIANH83VrSoBOpvz89rufRM8zImD3XXPr1aJm0MklOFElZKIidauoKfFr 3lYhoaoLtoYLNahrZQXolQTvK5oYNd9FGnfPDgKJm46cgIaJ33AK77J6VSXrwElSU+Fm NejCuxGmI+VPxEdhMOzGZ+HZPGvmQGlSgV5uI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTimclNp67GSt7sb_EWM_6kE3ABWS4X20iJo02F8J@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1BEA8649F0C00540AB2811D7922ECB6C9338B4D2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTil6lggj7AAMWZ31WG1b-J1MxUMI3M4FvKQMPAZ8@xxxxxxxxxxxxxx> <AANLkTincPzp_MHzKwHvnOjSe5Ci-fUftWlo7uClTk6VK@xxxxxxxxxxxxxx> <AANLkTimclNp67GSt7sb_EWM_6kE3ABWS4X20iJo02F8J@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
You mean, if NUMA is on, then PoD is disabled, but if NUMA is off, PoD
still works?

Or do you mean, this patch will break PoD functionality if accepted?

 -George

On Tue, Jul 6, 2010 at 7:07 AM, Dulloor <dulloor@xxxxxxxxx> wrote:
> WIth the NUMA allocator, pod is simply disabled as of now. This debug
> statement seeped through when testing that. Will take care of it :)
> However, I did test PoD for any regressions.
>
> -dulloor
>
> On Mon, Jul 5, 2010 at 2:55 AM, George Dunlap
> <George.Dunlap@xxxxxxxxxxxxx> wrote:
>> What's this line for:
>>
>>>+    if (nr_pages > target_pages)
>>>     {
>>>-        PERROR("Could not allocate memory.");
>>>-        goto error_out;
>>>+        pod_mode = 1;
>>>+        mem_flags |= XENMEMF_populate_on_demand;
>>>+        IPRINTF("I SHOULDN'T BE HERE !!\n");
>>
>> It's not clear what this patch does to the PoD logic... does it still
>> need some work, or should I try harder to grok it?  Have you tested it
>> in PoD mode?
>>
>>  -George
>>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel