WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] APIC errors resulting from too early set_timer()

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] APIC errors resulting from too early set_timer()
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 29 Jun 2010 10:53:39 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 29 Jun 2010 02:54:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir,

in c/s 17422 you moved the alloc_pdata scheduler callout into the
CPU_UP_PREPARE notifier handler, but the credit scheduler uses
set_timer() for a timer bound to the to be brought up CPU from
sched_alloc_pdata(), with the resulting send_IPI_mask() targeting
the not yet started CPU, thus (on my AMD systems at least)
resulting in APIC send accept errors.

I see three possible fixes, neither really nice imo: Either a second
callout (from CPU_ONLINE), or a credit scheduler specific notifier
(handling CPU_ONLINE), or binding the timer initially to the current
CPU, and migrate it to the target CPU as soon as that one's online.

Do you favor any one of these, or do you see any alternative?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>