WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxc: Fix Segmentation fault of xend

To: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc: Fix Segmentation fault of xend
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 21 Jun 2010 15:03:16 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 21 Jun 2010 07:05:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C1C6245.9050402@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4C1C6245.9050402@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yu Zhiguo writes ("[Xen-devel] [PATCH] libxc: Fix Segmentation fault of xend"):
> If /proc/xen/privcmd cannot be opened,
> start xend occurs Segmentation fault.
> Add check to fix it.

This change is not correct.

>  void xc_clear_last_error(xc_interface *xch)
...
> -    xch->last_error.message[0] = '\0';
> +    if (xch) {

It is wrong to call xc_clear_last_error with a NULL xc_interface*.
If xend is doing this it is probably a bug in the python xc lowlevel
interface.  Can you get a stack trace please so that we can fix the
call site ?

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel