Re: [Xen-devel] [PATCH] apic: clean up msr handling

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Friday 11 June 2010 17:57:58 Keir Fraser wrote:
> On 11/06/2010 16:51, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> >> Hm, I didn't spot that one. It's odd since I thought Christoph was
> >> changign macros into inlien functions where possible. Maybe he just
> >> changes in whichever direction makes his patch bigger? ;-)
> >
> > No, this change has to do with 'smp_processor_id() undefined'.
> > The root problem is a circular dependency with inclusion of headers.
> > The right fix is to clean up the headers.
>
> Yep, that's what I did.

Yes, I saw that in c/s 21605. Thanks for doing this.

But this is not what I meant by 'clean up the headers'.
For example, when you do

    touch xen/include/asm-x86/apic.h

then in the next build files that have nothing to do with
apic get recompiled because apic.h is indirectly included.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel