WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1
From: eXeC001er <execooler@xxxxxxxxx>
Date: Sun, 30 May 2010 16:21:30 +0400
Cc: Boris Derzhavets <bderzhavets@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 30 May 2010 05:22:25 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=HMvQQrSexOnayP0kIQ569AyToGg7tX4oTM3VbAy77SM=; b=KYnDsB1bMlyxP3tAiqDBMuKAsTjovbEl6b0dW2cYkjem79XzwbkWxgX2Pwwd62uDRB 7d53CebL6rtht88zUPEXbxpAb37J6Wd6w9bzfp+7gT8L0U9dPD+rjjXRkKq88+PeDi2m nnwo4tM/LXUIJ6XHSUtVhN1muKKV3IGawL8Xo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UQ2pprSABcAJjHEY4YDXDtkv47fcWaRC+4xG0+FHHFE2kaaXySBiEljMp/30KC+RzM W4nhLijsqIRbJdfstTssEs8oisMVVM2kt8npbf3Rye7Vi3YE7X0wCkcE75lHOHXBbKey K27zoKPMEBW2gguufppWAWiLYnH3hF51U2VE0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8280C51.164DD%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100530103753.GD17817@xxxxxxxxxxx> <C8280C51.164DD%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
My python-experience is small, but i tied to rewrite.
New in attach.

2010/5/30 Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
On 30/05/2010 11:37, "Pasi Kärkkäinen" <pasik@xxxxxx> wrote:

> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote:
>>    I have already sent a patch 1 weak ago. (blktap2_control_func.patch)
>>    repeat in attach.
>>    Thanks.
>
> Ok, thanks.
>
> Keir: I guess this is not committed yet?

I'm not too happy about the sleep(5). I guess if there's no better solution
coming up I should just whack this patch in?

 -- Keir

> -- Pasi
>
>>    2010/5/30 Pasi Kärkkäinen <[1]pasik@xxxxxx>
>>
>>      On Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote:
>>>      I've attempted to install Nexenta Core 3 image under Xen 4.0
>>      (2.6.32.13
>>>      pvops) on top of F13. Sample nexenta3.cfg profile contains 4
>>      lines like
>>>      this:-
>>>
>>>      disk=['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from sample)
>>>
>>>      It generates message
>>>      Â File 'vhd:/path/.../disk.img' doesn't exist.
>>>
>>>      Boris.
>>>      P.S. It was already in one of the threads @xen-users.
>>>
>>>    This bug in "def _parse_uname(uname):"
>>      (tools/python/xen/util/blkif.py)
>>>    (taptype, fn) = fn.split(":", 1) >>>>>>Â (taptype, fn) =
>>      fn.split(":",
>>>    2)[1:3]
>>
>>      Can you send a proper patch, as unified diff (diff -u), with a
>>      Signed-off-by line?
>>      -- Pasi
>>
>> References
>>
>>    Visible links
>>    1. mailto:pasik@xxxxxx
>
>> diff -r d0420ab97345 tools/python/xen/util/blkif.py
>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100
>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400
>> @@ -87,7 +87,7 @@
>>                  fn = "/dev/%s" %(fn,)
>>
>>          if typ in ("tap", "tap2"):
>> -            (taptype, fn) = fn.split(":", 1)
>> +            (taptype, fn) = fn.split(":", 2)[1:]
>>      return (fn, taptype)
>>
>>  def blkdev_uname_to_file(uname):
>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py
>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 2010 +0100
>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 2010 +0400
>> @@ -3292,6 +3292,7 @@
>>                  fn = BOOTLOADER_LOOPBACK_DEVICE
>>
>>              try:
>> +                time.sleep(5)
>>                  blcfg = bootloader(blexec, fn, self, False,
>>                                     bootloader_args, kernel, ramdisk, args)
>>              finally:
>> @@ -3299,7 +3300,7 @@
>>                      log.info("Unmounting %s from %s." %
>>                               (fn, BOOTLOADER_LOOPBACK_DEVICE))
>>
>> -                    dom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEVICE)
>> +                    dom0.destroyDevice(devtype, BOOTLOADER_LOOPBACK_DEVICE)
>>
>>              if blcfg is None:
>>                  msg = "Had a bootloader specified, but can't find disk"
>



Attachment: bltap2_control_func.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>