WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xl: Move "extern" declarations to xl.h

Declarations (as opposed to definitions) of external objects should
not appear in .c files.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 tools/libxl/xl.c |    3 ---
 tools/libxl/xl.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
index 82ab873..77eaa7b 100644
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -31,9 +31,6 @@
 #include "libxl_utils.h"
 #include "xl.h"
 
-extern struct libxl_ctx ctx;
-extern int logfile;
-
 void log_callback(
     void *userdata, int loglevel, const char *file,
     int line, const char *func, char *s)
diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h
index faf784a..450a12f 100644
--- a/tools/libxl/xl.h
+++ b/tools/libxl/xl.h
@@ -74,4 +74,7 @@ void help(char *command);
 extern struct cmd_spec cmd_table[];
 extern int cmdtable_len;
 
+extern struct libxl_ctx ctx;
+extern int logfile;
+
 #endif /* XL_H */
-- 
1.5.6.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel