WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC] Physical hot-add cpus and TSC

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (xen-devel@xxxxxxxxxxxxxxxxxxx)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC] Physical hot-add cpus and TSC
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 26 May 2010 22:26:10 +0100
Cc:
Delivery-date: Wed, 26 May 2010 14:29:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6b217ece-8fcf-430e-bb76-9883f798750d@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr9DCRUdsbAwjwNShi1j/opExZiCAADerkz
Thread-topic: [Xen-devel] [RFC] Physical hot-add cpus and TSC
User-agent: Microsoft-Entourage/12.24.0.100205
On 26/05/2010 20:46, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> It depends how physical CPU hotplug is implemented doesn't it. I expect
>> there's sufficient firmware involved in such an operation that TSCs
>> could
>> get synced up before host software gets a look in. I don't think we can
>> comment on whether or not there is an issue here without more
>> information.
>> Also, one reason Intel pushed the CPU hotplug logic is for RAS, and
>> offlining CPUs that throw errors, which can clearly be supported with
>> no concerns over TSC sync.
> 
> OK, then would you accept a patch that disables physical cpu-hot-add
> (but not delete) unless enabled with a boot option, if the patch
> includes sufficient commenting and dmesg to explain the ramifications?
> Then in future if it turns out that TSC syncing is mostly always
> handled by firmware (doubtful but possible), the default for the
> boot option can be reversed.

If the patch will be acked by the Intel authors of the cpu hotplug stuff
then yes.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel