WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual

To: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual address space for
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 25 May 2010 16:11:52 +0100
Cc:
Delivery-date: Tue, 25 May 2010 08:15:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C821A5A7.15454%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr8Ga96QQxaaxmtQ+G3AJYcT9ueDwAAfLHFAAA+JJA=
Thread-topic: [Xen-devel] [PATCH] HVM guests are allowed to use the entire virtual address space for
User-agent: Microsoft-Entourage/12.24.0.100205
Put another way, I'd rather ASSERT(!is_hvm_vcpu(current)) than further
reinforce the current confusion around these macros by supporting an
obsolete usage.

 -- Keir

On 25/05/2010 16:04, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> I think this is already handled correctly by guest_access.h, which is what
> really matters. Nowadays copy_{to,from}_user (but not __copy_{to,from}_user)
> are mainly for private usage only by the guest-access macros, and just a few
> other arch-dependent PV_specific bits of code. Of course the __ versions are
> still generally useful as 'copy but catch any fault' functions.
> 
>  -- Keir
> 
> On 25/05/2010 15:49, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
> 
>> whatever they want, without any Xen hole.  __addr_ok() is therefore
>> always true for such guests.
>> 
>> Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>> 
>> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel