WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix save or snapshot at kernel loading time with

To: "James (song wei)" <jsong@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix save or snapshot at kernel loading time with HVM vm
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 19 May 2010 08:47:04 +0100
Cc:
Delivery-date: Wed, 19 May 2010 00:48:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <28604661.post@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr3HtNEyAg0p/yeT+CArIjxo9NMuwACKXEL
Thread-topic: [Xen-devel] [PATCH] fix save or snapshot at kernel loading time with HVM vm
User-agent: Microsoft-Entourage/12.24.0.100205
On 19/05/2010 07:44, "James (song wei)" <jsong@xxxxxxxxxx> wrote:

>>     Sorry for not descripting this issue clearly.  When I do save at the
>> beginning of HVM guest booting(first stage - loading kernel), I found
>> guest os destoryed after saving completely.

Well, that's expected isn't it? Normally, saving a guest should save its
state to a file and destroy the guest, so that the saved state can be safely
resumed later.

>> So I see the code and get this flow:
>> xc_save()( here, call this function, when loading the kernel at the time
>> of guest booting. Event channel haven't been initialized,so that go to
>> compat_suspend() path in suspend()(save.c) -->> then, notify  the thread
>> named saveInputHandler in xend with a string "suspend". so  that
>> dominfo.shutdown is invoked.

That's required. We need the guest to shutdown with state SHUTDOWN_suspend,
so that we can save a consistent snapshot of its state. If you skip the
shutdown then you break domain save in the absence of PV drivers. It will be
broken because the guest will continue to run while xc_save does its work --
hence it will not save a consistent snapshot of the guest state.

 -- Keir

>> So, VM shutdown after do saving operator.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>