WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [pvops-dom0]Update MCE LOG data

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Kleen, Andi" <andi.kleen@xxxxxxxxx>
Subject: [Xen-devel] RE: [pvops-dom0]Update MCE LOG data
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Tue, 20 Apr 2010 09:16:50 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Apr 2010 18:18:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BCCB4C0.4040601@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659731D797FC3@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4BCCB4C0.4040601@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrf+gJlX2PGAo5MT5WGs2MysZs+3gAKZ98w
Thread-topic: [pvops-dom0]Update MCE LOG data
Hi, Jeremy
It's compatible with Andi's future newer mce structure.
And also it should be also compatible with old mcelog version, I noticed mcgcap 
is put at the tail of new mce structure in kernel. 
It should have same behavior as kernel.

Re-Paste the patch for adding sign off info.

Thanks& Regards,
criping

-----Original Message-----
From: Jeremy Fitzhardinge [mailto:jeremy@xxxxxxxx] 
Sent: Tuesday, April 20, 2010 3:54 AM
To: Ke, Liping
Cc: Jiang, Yunhong; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [pvops-dom0]Update MCE LOG data

On 04/19/2010 01:55 AM, Ke, Liping wrote:
> Hi, Jeremy and all
> This small patch is to pass mcg_cap information from XEN to DOM0 since now 
> new pv-ops kernel's mce data structure is changed and need this mcg_cap 
> information.
>   

Is this forwards and backwards compatible?

    J

> Thanks& Regards,
> Criping
>
>
>
>
> From 475b637e8dabb32446ee28e6b1235729e4b0f4bb Mon Sep 17 00:00:00 2001
> From: Liping Ke <liping.ke@xxxxxxxxx>
> Date: Mon, 19 Apr 2010 16:42:48 +0800
> Subject: [PATCH] Update MCE LOG data
> More mce data is provided in new DOM0 kernel, we need to pass
> mcg_cap information from XEN to DOM0 in vIRQ accordingly.
>
> ---
>  drivers/xen/mce.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/xen/mce.c b/drivers/xen/mce.c
> index b354dc8..8758e75 100644
> --- a/drivers/xen/mce.c
> +++ b/drivers/xen/mce.c
> @@ -72,6 +72,7 @@ static int convert_log(struct mc_info *mi)
>       m.socketid = g_physinfo[i].mc_chipid;
>       m.cpu = m.extcpu = g_physinfo[i].mc_cpunr;
>       m.cpuvendor = (__u8)g_physinfo[i].mc_vendor;
> +     m.mcgcap = g_physinfo[i].mc_msrvalues[0].value;
>       x86_mcinfo_lookup(&mic, mi, MC_TYPE_BANK);
>       do {
>               if (mic == NULL || mic->size == 0)
> @@ -83,6 +84,7 @@ static int convert_log(struct mc_info *mi)
>                       m.addr = mc_bank->mc_addr;
>                       m.tsc = mc_bank->mc_tsc;
>                       m.bank = mc_bank->mc_bank;
> +                     m.finished = 1;
>                       /*log this record*/
>                       mce_log(&m);
>               }
>   

Attachment: 0001-Update-MCE-LOG-data.patch
Description: 0001-Update-MCE-LOG-data.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>