WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]ACPI: re-enable mwait for xen cpuidle

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]ACPI: re-enable mwait for xen cpuidle
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 02 Apr 2010 15:46:27 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>
Delivery-date: Fri, 02 Apr 2010 07:47:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7DBBD6C.F83A%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrSJwfP1cRYbKunSoq1Ihm8FHUCfgAA7V8QAAbiibAACHVCgAACIm5TAACn8JQ=
Thread-topic: [Xen-devel] [PATCH]ACPI: re-enable mwait for xen cpuidle
User-agent: Microsoft-Entourage/12.24.0.100205
Think about it some more: Since this is about partial enabling of
MONITOR/WAIT, just to get C-state info to Xen -- i.e., something a bit hacky
anyway -- the right answer is for Linux to lie to itself and your 2nd patch
attempt is best. I would think of Xen advertising the fature to dom0 via
CPUID as meaning that the guest can use it as a 1st-class feature itself,
which is not the case.

 -- Keir

On 02/04/2010 15:27, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> It also has wider impact, including questionable effect on existing dom0
> kernels which have never been tested with MONITOR/MWAIT present in
> virtualised CPUID. I'm not sure about making this change even in current
> xen-unstable (but not dead against it), and there's no chance for 4.0 and
> 3.4 branches.
> 
>  -- Keir
> 
> On 02/04/2010 14:41, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> 
>> The 3rd choice: don't clear MWAIT feature in xen. This should be the best
>> choice.
>> 
>> Jimmy
>> 
>> X86: re-enable mwait for xen cpuidle
>> 
>> Xen hypervisor doesn't export mwait feature to dom0, but latest Linux kernel
>> start to check this feature while initializing _PDC object. Pass the MWAIT
>> feature to dom0 to let dom0 got & pass to xen correct C state info.
>> 
>> Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>
>> 
>> diff -r 537451477469 xen/arch/x86/traps.c
>> --- a/xen/arch/x86/traps.c Thu Apr 01 09:55:27 2010 +0100
>> +++ b/xen/arch/x86/traps.c Sat Apr 03 05:26:53 2010 +0800
>> @@ -776,7 +776,6 @@ static void pv_cpuid(struct cpu_user_reg
>>          __clear_bit(X86_FEATURE_PBE, &d);
>>  
>>          __clear_bit(X86_FEATURE_DTES64 % 32, &c);
>> -        __clear_bit(X86_FEATURE_MWAIT % 32, &c);
>>          __clear_bit(X86_FEATURE_DSCPL % 32, &c);
>>          __clear_bit(X86_FEATURE_VMXE % 32, &c);
>>          __clear_bit(X86_FEATURE_SMXE % 32, &c);
>> @@ -814,7 +813,6 @@ static void pv_cpuid(struct cpu_user_reg
>>          __clear_bit(X86_FEATURE_SKINIT % 32, &c);
>>          __clear_bit(X86_FEATURE_WDT % 32, &c);
>>          break;
>> -    case 5: /* MONITOR/MWAIT */
>>      case 0xa: /* Architectural Performance Monitor Features */
>>      case 0x8000000a: /* SVM revision and features */
>>      case 0x8000001b: /* Instruction Based Sampling */
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel