Re: [Xen-devel] [PATCH] xen: move viridian defines to header

To:	Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xen: move viridian defines to header
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Thu, 01 Apr 2010 09:50:53 +0100
Cc:
Delivery-date:	Thu, 01 Apr 2010 01:51:35 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<201004011030.59969.Christoph.Egger@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcrRddYhiteacSglQm2lrtBw5sIebgAAplY0
Thread-topic:	[Xen-devel] [PATCH] xen: move viridian defines to header
User-agent:	Microsoft-Entourage/12.24.0.100205

On 01/04/2010 09:30, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi!
> 
> Attached patch moves viridian defines into viridian header.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

I don't consider this a clean up by itself. It's nicer to define things in a
.c file if they are only sued in that .c file. Also moving the MSRs out but
not other viridian-architectural defines like the MSR flag definitions and
hypercall status codes seems inconsistent.

I would consider this as part of a patch series where later patches that I
actually care about make use of this change. On its own, it gets a nack.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] xen: move viridian defines to header