WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[PATCH] Re: [Xen-devel] Re: [PATCH] to fix ACPI slit table access at ru

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: [PATCH] Re: [Xen-devel] Re: [PATCH] to fix ACPI slit table access at runtime
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 25 Feb 2010 13:35:45 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 25 Feb 2010 05:36:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7AC28BA.B5D0%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B868329020000780003144E@xxxxxxxxxxxxxxxxxx> <C7AC28BA.B5D0%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 25.02.10 14:16 >>>
>Given we agree the current situation is a bug, could you make up a patch
>along the lines of what you prefer to see? Because my default action will be
>simply to ifdef the code, as NUMA-on-i386 is not much a concern of mine.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2010-02-19.orig/xen/arch/x86/numa.c 2010-01-13 18:58:11.000000000 +0100
+++ 2010-02-19/xen/arch/x86/numa.c      2010-02-25 14:27:14.000000000 +0100
@@ -30,7 +30,7 @@ struct node_data node_data[MAX_NUMNODES]
 
 /* Mapping from pdx to node id */
 int memnode_shift;
-static typeof(*memnodemap) _memnodemap[2];
+static typeof(*memnodemap) _memnodemap[64];
 unsigned long memnodemapsize;
 u8 *memnodemap;
 
@@ -90,6 +90,7 @@ static int __init populate_memnodemap(co
 
 static int __init allocate_cachealigned_memnodemap(void)
 {
+#ifndef __i386__
        unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap));
        unsigned long mfn = alloc_boot_pages(size, 1);
 
@@ -108,6 +109,13 @@ static int __init allocate_cachealigned_
        memnodemapsize = size / sizeof(*memnodemap);
 
        return 0;
+#else
+       printk(KERN_ERR
+              "Memory to Node hash needs %lu entries, got only %zu\n",
+              memnodemapsize, ARRAY_SIZE(_memnodemap));
+       memnodemapsize = 0;
+       return -1;
+#endif
 }
 
 /*



Attachment: i386-numa-not-boot-alloc.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel