 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables c
| To: | "Wei, Gang" <gang.wei@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Thu, 25 Feb 2010 11:58:26 +0000 |
| Cc: | Jan Beulich <JBeulich@xxxxxxxxxx> |
| Delivery-date: | Thu, 25 Feb 2010 03:59:58 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <E6467867A6B05E4FA831B7DF29925F5C40BBA48B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acq13lKhxRtlttZBS6OrDhFD9qjUSwAM4Oye |
| Thread-topic: | [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 25/02/2010 05:49, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> /* Now FACS... */
> - if (fadt->header.revision >= FADT2_REVISION_ID)
> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0)
> facs_pa = fadt->Xfacs;
> else
> facs_pa = (uint64_t)fadt->facs;
I think Linux in this case falls back to facs if Xfacs is zero, rather than
always using facs if facs is non-zero. So more like:
if (fadt->header.revisions >= FADT2_REVISION_ID && fadt->Xfacs)
...
What do you think? And I was looking at Linux 2.6.27 -- has behaviour there
chanegd since then?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Question about xen/stable branch in kernel pv_ops, Pasi Kärkkäinen |
|---|---|
| Next by Date: | [Xen-devel] Re: [PATCH] to fix ACPI slit table access at runtime, Keir Fraser |
| Previous by Thread: | RE: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case, Wei, Gang |
| Next by Thread: | Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
