xen-devel

[Top] [All Lists]

Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedbyswiotl

from [Ronny . Hegewald]

[Permanent Link][Original]

To:	<konrad.wilk@xxxxxxxxxx>
Subject:	Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedbyswiotlb
From:	Ronny.Hegewald@xxxxxxxxx
Date:	Fri, 05 Feb 2010 21:09:03 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Fri, 05 Feb 2010 12:09:24 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>> No, your first statement was correct. It would always return the same mask 
>for 32-bit and 64-bit, because of the 32-bitness of the return-variable 
>'dma_mask'.
>> 
>> So the following patch maybe would be more appropriate?
>
>I think it isn't neccessary. The 'dmal_alloc_coherent_mask' returns an
>unsigned long. On 32-bit 'unsigned long' is a 4-byte value, and
>on 64-bit that is 8-byte value. 

Oh yes, right, didnt thought about that ....

So I think your previous patch:
>http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00038.html
>is correct as when it is compiled under 64-bit it would return a 64-bit
>value and when compiled under 32-bit, it would return a 32-bit value.

As it seems that the patch wasn't noticed i will resend it. Can i add a 
Reviewed-by (or Acked-by) from you to the patch, so it gets more attention?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedbyswiotlb, Ronny . Hegewald <= Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedbyswiotlb, Konrad Rzeszutek Wilk

Previous by Date:	[Xen-devel] [PATCH 11 of 12] blkback/blktap2: simplify address translations, Daniel Stodden
Next by Date:	Re: [Xen-devel] pvops netconsole, Brad Plant
Previous by Thread:	[Xen-devel] RE: Host Numa informtion in dom0, Ian Pratt
Next by Thread:	Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedbyswiotlb, Konrad Rzeszutek Wilk
Indexes:	[Date] [Thread] [Top] [All Lists]