WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 29 Jan 2010 07:06:55 +0000
Cc: "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Thu, 28 Jan 2010 23:07:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EB8593BCECAB3D40A8248BE0B6400A3835A4384E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqfEjBdAvKTlDZES9GP92/daWtXOgBn3NcB
Thread-topic: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
User-agent: Microsoft-Entourage/12.23.0.091001
On 27/01/2010 05:33, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> HVM vcpu hotplug: Fix acpi method NTFY bug
> 
> Cancel define method NTFY by using decision_tree, it will block vcpu add and
> result in other unpredicted error. The second reason is method NTFY is not key
> path and no necessary using complicated decision_tree to reduce scan time. The
> third reason is, the scan loop defined by method PRSC is not necessary equal
> to the scan loop defined by method NTFY, and not necessary equal to 2^n.
> 
> Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>

You'll have to point out how this fixes the NTFY method I'm afraid -- the
two methods look exactly equivalent to me, except the existing method should
on average execute with far fewer compares, and hence looks preferable.

And please don't send updates to dsdt.c in patches which update DSDT. I
always re-generate it myself anyway, and it makes your patch 1000x bigger.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel