WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [xen-devel][PATCH] PV driver compatibility

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Subject: Re: [xen-devel][PATCH] PV driver compatibility
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 22 Jan 2010 07:31:44 +0000
Cc: ksrinivasan <ksrinivasan@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 21 Jan 2010 23:32:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C77E7BD0.712C%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <C77E7BD0.712C%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010-01-21 at 21:46 +0000, Keir Fraser wrote: 
> On 21/01/2010 20:38, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> 
> >> You introduced the magic port value check, in xen-unstable:19964.
> > 
> > I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> > how the unmodified drivers part of the change relates to the comment :-(
> 
> Yes, I wonder if it was even meant to be checked in. Or if it's an
> accidental merge of two patches both of which you intended to go in.

Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
they should be used, which suggests I wasn't quite ready to send the
patch...

> 
> I'm not sure unconditional unplug, as implemented, is a good idea. I can
> imagine people with setups in which emulated devices coexist with pv
> devices. Such a setup breaks if emulated devices all get unplugged when pv
> drivers load. Presumably in the environment this patch came from (Citrix
> XenServer) such a situation is disallowed, but I'm not so sure about
> proscribing it more generally.

The protocol allows for coarse grained selection of which devices to
unplug:
6) The drivers write a two-byte bitmask of devices to unplug to IO
   port 0x10.  The defined fields are:

   1 -- All IDE disks (not including CD drives)
   2 -- All emulated NICs
   4 -- All IDE disks except for the primary master (not including CD
        drives)

There is scope for extending this to a more explicit bitmask allowing
individual devices to be selected, if people are interested in that.

> Some people do want unplug though, so I think making it a non-default module
> option is a good idea.
> 
>  -- Keir
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel