WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Ping: c/s 20526 (tools: avoid cpu over-commitment if num

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "andre.przywara@xxxxxxx" <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] Ping: c/s 20526 (tools: avoid cpu over-commitment if numa=on)
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2010 08:29:06 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 13 Jan 2010 00:29:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B4D8F1C02000078000299EC@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqUKJhFnj4tw7uzQIe/UC5U91wilgAAd/xU
Thread-topic: [Xen-devel] Ping: c/s 20526 (tools: avoid cpu over-commitment if numa=on)
User-agent: Microsoft-Entourage/12.23.0.091001
On 13/01/2010 08:15, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> Andre,
> 
> I'm afraid this change isn't really correct:
> 
>> +                cores_per_node = info['nr_cpus'] / info['nr_nodes']
>> +                nodes_required = (self.info['VCPUs_max'] + cores_per_node -
>> 1) / cores_per_node
> 
> Simply using cores_per_node (as calculated here) as a divisor is bound
> to cause division-by-zero issues, namely when limiting the number of
> CPUs on the Xen command line (maxcpus=). I'm not sure though, what
> a reasonable solution to this might look like, since cores-per-node is
> a meaningless thing in an artificial setup like this, and may also be
> meaningless in asymmetric configurations. So perhaps we really need
> to iterate over nodes while summing up the number of CPUs they
> have until the number of needed vCPU-s was reached.

Yes, please!

 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>