Re: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch ioctl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2010-01-11 at 14:49 +0000, Jan Beulich wrote:
>  #define IOCTL_PRIVCMD_MMAPBATCH                                        \
>         _IOC(_IOC_NONE, 'P', 3, sizeof(privcmd_mmapbatch_t))
> +#define IOCTL_PRIVCMD_MMAP_BATCH                               \
> +       _IOC(_IOC_NONE, 'P', 4, sizeof(privcmd_mmap_batch_t)) 

Distinguishing the old vs new ioctl by only a _ in the middle seems a
bit horrid. MMAPBATCH2 would at least be less prone to confusion...

Why not take the opportunity to make the ioctl (and hypercall?)
interface 32 vs 64 agnostic by unconditionally using 64 bit sizes?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel