WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pvcpuid: mask TSC invariant bit for various circ

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pvcpuid: mask TSC invariant bit for various circumstances
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2009 00:22:06 +0000
Cc:
Delivery-date: Mon, 26 Oct 2009 17:22:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <8a95a56e-c387-46c7-a7d2-5a84bdfd1485@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpWkfA1rHLCkhmYRf+XzElg9eVBfgACZNSN
Thread-topic: [Xen-devel] [PATCH] pvcpuid: mask TSC invariant bit for various circumstances
User-agent: Microsoft-Entourage/12.20.0.090605
On 26/10/2009 23:12, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> pvcpuid: mask TSC invariant bit for PV domains if migration
> is not disabled and TSC is not emulated
> 
> (Need similar patch for HVM domain)
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>

This only affects PV domUs. I suggest patching pv_cpuid() to catch dom0, and
then really all domUs should be handled by xc_cpuid_apply_policy(), which
pushes CPUID info down to the hypervisor, as called from xend's
image.py:setCpuid(). The advantage of this is that the hypervisor does not
need to be informed of the 'disable_migrate' flag at all -- it can be
assumed to be true for dom0 -- and it can be handled entirely in the tools.
Hence I can get rid of the new domctl, which is nice.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel