 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH] trust new architecturally-defined TSC Invariant
| To: | Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] trust new architecturally-defined TSC Invariant bit on Intel systems |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 09 Oct 2009 20:20:40 +0100 |
| Cc: | |
| Delivery-date: | Fri, 09 Oct 2009 12:21:12 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <8099ee0f-6c0d-4966-ae07-bea9951dd272@default> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcpJE0MQlSMUH3iZSu69IYeVg9hKywAAlNUA |
| Thread-topic: | [PATCH] trust new architecturally-defined TSC Invariant bit on Intel systems |
| User-agent: | Microsoft-Entourage/12.20.0.090605 |
On 09/10/2009 20:03, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote: > Actually it did (avoid rendezvous), but I have to admit > it was accidental: I was trying to avoid the write_tsc's > not the rendezvous, and I didn't notice the additional > implication until I was looking at the difference between > my patch and yours. > > I'll look at this more in a few days... If you mean your test-and-goto in time_calibration_tsc_rendezvous(), that was just broken. You still raised the TIME_CALIBRATE_SOFTIRQ, but with uninitialised r->master_stime. And at that point you'd already rendezvoused all the CPUs, so done the expensive bit anyway. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] RE: [PATCH] trust new architecturally-defined TSC Invariant bit on Intel systems, Dan Magenheimer |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] make blkfront/blktagp2 respect the elevator=xyz command line option, Keir Fraser |
| Previous by Thread: | [Xen-devel] RE: [PATCH] trust new architecturally-defined TSC Invariant bit on Intel systems, Dan Magenheimer |
| Next by Thread: | Re: [Xen-devel] [PATCH]: Implement bzip2 and LZMA loaders / xen-unstable stubdom pvgrub support, Pasi Kärkkäinen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
