WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] xenstore ring overflow when too many watches are fired

To: James Harper <james.harper@xxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xenstore ring overflow when too many watches are fired
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 08 Oct 2009 13:58:02 +0100
Cc:
Delivery-date: Thu, 08 Oct 2009 05:58:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AEC6C66638C05B468B556EA548C1A77D0177D86B@trantor>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpIBq1xI/hXC2nOST2UVLFiVzrk3AAAQduAAABKkIAAA4Y2ww==
Thread-topic: [Xen-devel] xenstore ring overflow when too many watches are fired
User-agent: Microsoft-Entourage/12.20.0.090605
On 08/10/2009 12:22, "James Harper" <james.harper@xxxxxxxxxxxxxxxx> wrote:

> Is it this function that prevents this tail-eating?

No.

> I hope I'm not just too tired to be thinking about this, but wouldn't
> that only return FALSE when the ring was full? It doesn't guarantee that
> there is enough space to write a message, and doesn't stop messages
> continuing to be written once the ring has overflowed. I can't seen any
> other relevant reference to rsp_prod or rsp_cons in xenstored.

Try grep. See xenstored_domain.c:writechn(). Takes a bunch of bytes to
write; returns how many were successfully written on this attempt. Uses
rsp_cons (via get_output_chunk()).

If we didn't get this right, we'd be screwed for reading any xenstore node
containing a large amount of data (we do sometimes have those).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>