WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 07 of 10] Transitive grant support

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Steven Smith <Steven.Smith@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 07 of 10] Transitive grant support
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 05 Oct 2009 09:23:49 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "joserenato.santos@xxxxxx" <joserenato.santos@xxxxxx>
Delivery-date: Mon, 05 Oct 2009 01:24:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AC9C42E0200007800017EF4@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpFki9VGDKvQJyZTwGoEF3UkrhDoAAAvqjn
Thread-topic: [Xen-devel] [PATCH 07 of 10] Transitive grant support
User-agent: Microsoft-Entourage/12.20.0.090605
On 05/10/2009 09:02, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> -    unsigned long frame;  /* Frame being granted.                     */
>> +    domid_t       trans_dom;
>> +    uint32_t      trans_gref;
>> +    uint32_t      frame;  /* Frame being granted.                     */
> 
> Using a uint32_t for a frame number is not valid anymore after the recent
> sparse physical memory support changes (and I don't think it would have
> been valid on ia64 even before).

What about the 'uint32_t frame' in grant_entry_v2_t -- I'm surprised you
didn't mention that also? It's most critical we get the sizing of that
correct, while we're rev'ing a public interface. Given the definition of
__spacer[], it looks like there's space to have a full 'uint64_t frame' in
that structure too, no problem. A bit of field reordering might be needed to
make everything align naturally yet compactly, is all, I think?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>