WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH] VNIF: Using smart polling instead of event notifi

To: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] VNIF: Using smart polling instead of event notification.
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 1 Oct 2009 11:03:07 +0100
Cc: Keir, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 01 Oct 2009 03:03:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457501CEB99EAD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <EADF0A36011179459010BDF5142A457501CEB99EAD@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
You are adding a netfront specific field to the generic ring structure?
That seems rather ugly. 

Is this even necessary as a piece of shared state? Once netback and
netfront have agreed, via xenstore, to use the feature netback seems to
set the flag every time it would have previously notified netfront.

Ian.

On Thu, 2009-10-01 at 01:22 +0100, Xu, Dongxiao wrote:
> Resend and put the patch in attachment. 
> 
> Patch the Xen version of ring.h
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> 
> diff -r 8fc927798476 xen/include/public/io/ring.h
> --- a/xen/include/public/io/ring.h      Tue Sep 01 11:36:51 2009 +0100
> +++ b/xen/include/public/io/ring.h      Thu Oct 01 02:11:45 2009 +0800
> @@ -97,7 +97,8 @@ struct __name##_sring {
>  struct __name##_sring {                                                 \
>      RING_IDX req_prod, req_event;                                       \
>      RING_IDX rsp_prod, rsp_event;                                       \
> -    uint8_t  pad[48];                                                   \
> +    uint8_t  netfront_smartpoll_active;                                 \
> +    uint8_t  pad[47];                                                   \
>      union __name##_sring_entry ring[1]; /* variable-length */           \
>  };                                                                      \
>                                                                          \
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel