| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] RE: Biweekly VMX status report. Xen: #20255 & Xen0:#b6ba
|
To: |
Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] RE: Biweekly VMX status report. Xen: #20255 & Xen0:#b6ba0... |
|
From: |
Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Date: |
Wed, 30 Sep 2009 10:20:22 +0100 |
|
Cc: |
"Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Xu, Jiajun" <jiajun.xu@xxxxxxxxx>, "Han, Weidong" <weidong.han@xxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx> |
|
Delivery-date: |
Wed, 30 Sep 2009 02:20:58 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20090930090810.GA9914@xxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcpBrYqSrL2u9NU1RiubpVY6Uw3j9wAAbG0S |
|
Thread-topic: |
[Xen-devel] RE: Biweekly VMX status report. Xen: #20255 & Xen0:#b6ba0... |
|
User-agent: |
Microsoft-Entourage/12.20.0.090605 |
On 30/09/2009 10:08, "Tim Deegan" <Tim.Deegan@xxxxxxxxxxxxx> wrote:
>> So, we could 'fix' by giving ept_sync_domain() its own lock, but my
>> suspicion would be that any paths through the p2m code that are not holding
>> the p2m_lock probably need to be fixed. Adjusting p2m entries without the
>> lock held sounds racey to me.
>
> The {set,clear}_mmio_p2m_entry functions that were added for Vt-D MMIO
> passthrough don't seem to do any locking. (Actually, I don't see why
> the mmio passthrough needs its own interface to the p2m at all.)
> Untested but obvious fix attached.
I'd like Intel to test this before checkin, mainly to make sure it is
complete enough. I have a feeling the vmx_set_uc_mode() function may also
enter the p2m code without the hindrance of locking.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home