WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Patch for 2.6.31-rc9

To: xen-devel@xxxxxxxxxxxxxxxxxxx, Andy Georges <andy.georges@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Patch for 2.6.31-rc9
From: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Date: Tue, 22 Sep 2009 08:14:32 -0700 (PDT)
Cc:
Delivery-date: Tue, 22 Sep 2009 08:15:00 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1253632472; bh=FnJWy27P4Myeu0hMiOINzXTdLHnnjQwr9CvOo/LgtR0=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=wq6l+zcIkfczFUMBaX2bboKFaN5t4w+tZbP4niNUYbVTOBsyJwpCKViveb+rL5cIyvoQ0FqHvBXOXkSt4rraOykJ9ocZN+jwREYRBSEApRIyG6po/3RV5oSdjT3k36y6kdveK/M2mYLwyiwxIpTfuahDE4bSuJjGhUVw/tBa+sA=
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=RYpj79VLkpBX8EPFEo9uc3OPS+rtuf13Wa4+uxWbCozgZyG1rzo8DUCWoEAsX1BYPLiR9Fwe8FeaYAfGV7zykD25p+oTlgChrDAiFo7R5BpPZPTmi+hKaLabZP8XeY4cgCl8FXVb0TRsRBVKm24fUfh7zTIg2aKV/Y1+bAFmcG4=;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A46EBCA-0FCF-467B-93F9-6734B8AAE3C8@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This seems a kind of mystery for me. Message from Jeremy (@xen-devel) , suggesting to add "# <linux/dma-mapping.h>"  to file "include/linux/swiotlb.h"  was made about 2-3 weeks ago. Since then kernel's git repo got a lot of commits, moved to 2.6.31. Swiotlb issue was tracked down and fixed by Konrad and etc.
However, include/linux/swiotlb.h stays the same.

Boris.

--- On Tue, 9/22/09, Andy Georges <andy.georges@xxxxxxxxxxxxx> wrote:

From: Andy Georges <andy.georges@xxxxxxxxxxxxx>
Subject: [Xen-devel] Patch for 2.6.31-rc9
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Date: Tuesday, September 22, 2009, 10:55 AM

Hi,


When building the 2.6.31-rc9 kernel with xen patches, obtained as per the instructions on http://wiki.xensource.com/xenwiki/XenParavirtOps, i.e.,

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git linux-2.6-xen
$ cd linux-2.6-xen
$ git checkout origin/xen/master -b xen/master
$ git pull
$ make menuconfig

I ran into the following error:

root@assail:/usr/src/linux-2.6-xen# make -j 12 modules
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/gpu/drm/ttm/ttm_agp_backend.o
  CC [M]  drivers/gpu/drm/via/via_irq.o
  CC [M]  drivers/gpu/drm/ttm/ttm_memory.o
  CC [M]  drivers/gpu/drm/via/via_drv.o
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:4,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
include/linux/swiotlb.h:48: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:48: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/swiotlb.h:51: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:63: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:68: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:72: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:76: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:80: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:84: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:89: warning: ‘enum dma_data_direction’ declared inside parameter list
include/linux/swiotlb.h:94: warning: ‘enum dma_data_direction’ declared inside parameter list
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:8,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h: In function ‘get_dma_ops’:
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:29: error: dereferencing pointer to incomplete type
/usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:32: error: dereferencing pointer to incomplete type
In file included from /usr/src/linux-2.6-xen/arch/x86/include/asm/dma-mapping.h:36,
                 from /usr/src/linux-2.6-xen/arch/x86/include/asm/agp.h:8,
                 from drivers/gpu/drm/ttm/ttm_agp_backend.c:39:
<snip>

The last change to the kernel was:

commit 3973dcf8835207714f10ce4847fa57e9f35b8197
Merge: ebf47a1 7676973
Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Date:   Thu Sep 17 12:47:49 2009 -0700

    Merge commit 'xen/xen/xenfb' into xen/master

    * commit 'xen/xen/xenfb':
      xenfb: connect to backend before registering fb


The above issue can be resolved by the following patch:

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index cb1a663..f4ebffb 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -2,6 +2,7 @@
#define __LINUX_SWIOTLB_H

#include <linux/types.h>
+#include <linux/dma-mapping.h>

struct device;
struct dma_attrs;

I did get the patch from the Fedora list, after googling, so maybe somebody already has it lined up for inclusion (http://www.mail-archive.com/fedora-xen@xxxxxxxxxx/msg02913.html)?

Hope this helps,
-- Andy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>