 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while
| To: | Kouya Shimura <kouya@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while its IRQ is masked |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Thu, 10 Sep 2009 13:32:32 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Thu, 10 Sep 2009 05:33:01 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <7kd45z6s6z.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acox/KcYy1kJi5noQamRs5gfoZ9JuQAFh1by |
| Thread-topic: | [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while its IRQ is masked |
| User-agent: | Microsoft-Entourage/12.20.0.090605 |
On 10/09/2009 10:54, "Kouya Shimura" <kouya@xxxxxxxxxxxxxx> wrote: >> Not using pt_irq_masked() seems odd. Is it to avoid 859 IRQ mask checks, and >> if so why are you doing that? Why do we care that rombios twiddles the 8259 >> masks a bunch during boot? > > I guessed that the cost of freezing/thawing a timer with the 8259 mask > is higher than timer emulation. And the PIT timer is actually active > while rombios masks the 8259. > > If using pt_irq_masked() is desirable, I'll remake it. If your patch works without even any theoretical lost of correctness, then that makes it more attractive, obviously. Some evidence that the cost saving is at all measurable would also be good. Premature optimisation being evil, etc. ;-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | RE: [Xen-devel] RE: xen-unstable pci passthrough, Han, Weidong |
|---|---|
| Next by Date: | RE: [Xen-devel] Video Presentation on PCI Express x16 VGA Pass Through to Xen-based Windows XP Home Edition HVM Virtual Machine, Mr. Teo En Ming (Zhang Enming) |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while its IRQ is masked, Kouya Shimura |
| Next by Thread: | Re: [Xen-devel] [PATCH] x86 hvm: freeze PIT/LAPIC timer emulation while its IRQ is masked, Kouya Shimura |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
